synpress icon indicating copy to clipboard operation
synpress copied to clipboard

Upgrade Cypress to v10 and puppeteer to v15

Open maximgeerinck opened this issue 3 years ago • 10 comments

Description

  • Upgrade Cypress to v10
  • Upgrade puppeteer to v15
  • Make tests work standalone

maximgeerinck avatar Jun 29 '22 11:06 maximgeerinck

upgrade cypress to >10.2.x version so that Mac M1 users could use this package

rohaanmalik avatar Jul 12 '22 18:07 rohaanmalik

I'm getting a strange error:

Could not find a Cypress configuration file.

We looked but did not find a synpress.json file in this folder: /home/emory/app/tests/synpress

The file is there and synpress 1.2.0 works fine.

EDIT: needs a migration of the synpress config. I found moving tests/synpress/synpress.json to cypress.config.js and converting to new cypress format works.

ezpuzz avatar Jul 21 '22 12:07 ezpuzz

It would be great to get this merged, facing a lot of issues recently which I think are stemming from this.

Afitzy98 avatar Aug 02 '22 12:08 Afitzy98

I'm working from this commit currently, would be great if it can be merged so I can keep up-to-date with npm versions.

hardingjam avatar Aug 03 '22 07:08 hardingjam

Is there any outstanding work on this needed? Seems like we should move forward and merge this.

pavel-lens avatar Aug 08 '22 16:08 pavel-lens

I need a maintainer to approve

maximgeerinck avatar Aug 08 '22 16:08 maximgeerinck

@maximgeerinck I'm getting the following problem when I checked out this commit:

Could not find a Cypress configuration file.

We looked but did not find a tsconfig.json file in this folder: <project-path>/tests/e2e

Have you seen this problem?

pavel-lens avatar Aug 08 '22 18:08 pavel-lens

@maximgeerinck I'm getting the following problem when I checked out this commit:

Could not find a Cypress configuration file.

We looked but did not find a tsconfig.json file in this folder: <project-path>/tests/e2e

Have you seen this problem?

Did you follow the steps in the README.md ? it specifies to create a tsconfig file :)

maximgeerinck avatar Aug 09 '22 05:08 maximgeerinck

Strange, cypress was upgraded in dev, but no changes were made to actually make it compatible. Merged in dev to prepare for merge

maximgeerinck avatar Aug 09 '22 05:08 maximgeerinck

@maximgeerinck I'm getting the following problem when I checked out this commit:

Could not find a Cypress configuration file.

We looked but did not find a tsconfig.json file in this folder: <project-path>/tests/e2e

Have you seen this problem?

Did you follow the steps in the README.md ? it specifies to create a tsconfig file :)

I have tsconfig file. This happens as soon as I change the Synpress version from latest published version on NPM to commit hash of this PR. I see you pushed some code overnight.

pavel-lens avatar Aug 09 '22 06:08 pavel-lens

remote

happy to change it but do you have an example on how to test for remote repos ? At Refinable we're running this setup within a CI successfully for over a month now (as well as locally)

maximgeerinck avatar Sep 01 '22 13:09 maximgeerinck

@maximgeerinck @rohaanmalik @GustavoRSSilva @ezpuzz @Afitzy98 @hardingjam @svitekpavel

Hey, just wanted to let you know that synpress is updated to latest Cypress and Puppeteer and released as @synthetixio/[email protected].

Please keep in mind that support.js file is now required, take a look at updated readme.

drptbl avatar Sep 06 '22 21:09 drptbl

remote

happy to change it but do you have an example on how to test for remote repos ? At Refinable we're running this setup within a CI successfully for over a month now (as well as locally)

Sadly, I was not able to run synpress from this PR properly because of issues mentioned above. I was able to fix it on @synthetixio/[email protected].

By remote repos I meant adding synpress as dependency, instead of running e2e tests for synpress itself.

drptbl avatar Sep 06 '22 21:09 drptbl

Hey, I'm closing this PR for now as we have playwright instead of puppeteer and basically most of the code has been done.

Please reopen if you don't agree, thank you!

drptbl avatar Sep 11 '22 01:09 drptbl