synpress icon indicating copy to clipboard operation
synpress copied to clipboard

Published 20 hours ago • verified publisher icon Synthetixio

Stop transitively depending on Cypress

Open hasparus opened this issue 1 year ago • 2 comments

Hey! Firstly, thank you for Synpress. I've been using it for end-to-end tests of Subgraph Studio for a while already.

Motivation and context

Due to a design limitation in DefinitelyTyped, it doesn't support peerDependencies. This means that Synpress, even when used with Playwright, transitively depends on Cypress, and installs it for its users.

This is an issue, because installing Cypress means downloading a browser. It's not fast, and with it can fail with a socket timeout on flaky internet connections.

PRs that try to fix it get closed:

  • https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67000#pullrequestreview-1668488797
  • https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44962

Does it fix any issue?

Not that I know of.

Quality checklist

  • [x] I have performed a self-review of my code.

hasparus avatar Feb 07 '24 18:02 hasparus

@hasparus is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 07 '24 18:02 vercel[bot]

Thanks for PR @hasparus! We're currently working on new version of synpress (currently in alpha) which already fixes mentioned issue. Nevertheless I will considering merging this to stable version of synpress asap. 🙏

drptbl avatar Feb 20 '24 22:02 drptbl