synpress

synpress copied to clipboard

Motivation and context

Renaming wallets is important for managing financials

Clearly and concisely describe the feature added/isses being solved.

Does it fix any issue?

Adds functionality that isn't currently available in new dawn

#(issue)

Other useful info

N/A

Quality checklist

• [x] I have performed a self-review of my code.
• [x] If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
synpress	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2024 2:05pm

Hey! Thanks for the PR! 🖤

It's perfect except for a few super small details 😇

@Seroxdesign is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.

Hey! Thanks for the PR! 🖤

It's perfect except for a few super small details 😇

Thanks for taking the time to review, I pushed up a few changes that should make this more stable, specifically i removed the validation, made it so that I use a mouse click instead of an enter key, and removed a test spec I wrote for the English reserved names.

Good catches btw

I ran lint and redid the title, hopefully this is ready to go (:

@drptbl Can you handle this? Looks decent 👍

@drptbl can you please rerun this Validate Title check? Last one should've been valid, not sure why it failed. Any idea?

@duckception @drptbl either of you able to get this merged? The naming convention is being followed from what I understand but if not lmk what i'm doing wrong.