synpress

synpress copied to clipboard

Motivation and context

I work at Badger DAO and we are using this library in our Github action's workflow, we occasionally encounter inconsistent behavior. While it often executes as expected, there are instances where we face the following error:

[switchToMetamaskNotification] Max amount of retries to switch to metamask notification window has been reached. It was never found.

Does it fix any issue?

Increase retries helped us to make Github action's workflow always works for us

Quality checklist

• [x] I have performed a self-review of my code.

Hey! Thanks for the PR. This is the first time I've heard about this issue 🤔

With what values of RETRIES_SWITCH_TO_METAMASK_NOTIFICATION and RETRIES_WAIT_TO_BE_HIDDEN are you running your CI?

We have set RETRIES_SWITCH_TO_METAMASK_NOTIFICATION=100 in our .env file, but we're still using the default setting for RETRIES_WAIT_TO_BE_HIDDEN. I've added instructions for others who might want to change this default value.

Sorry for the long response time. I'm down to merge the change to RETRIES_SWITCH_TO_METAMASK_NOTIFICATION. Adding RETRIES_WAIT_TO_BE_HIDDEN makes no sense at all so it should be removed. What's the motivation behind CONFIRM_TRANSACTION_RETRIES_LIMIT? 120s is already high enough imo but I might be missing some important context here.