spotify-dl
spotify-dl copied to clipboard
Fix #171
Title
Fix problem with song covers being corrupt.
Details
Instead of just downloading the cover, it passes it though ffmpeg to ensure the format is jpg.
Testing
Downloaded the same playlist of #171 and running ffprobe didn't return any problems, also no apparent problems in file managers.
Checklist
[X] Ran eslint/prettier formatting [ ] Tests are passing (no tests yet) [X] Feature is considered complete
Issues this resolves
fixes and closes #171
there was also this pr i made to attempt to fix it, though its a more of "okay lets try again" might aswell chuck these changes in with yours if you want
https://github.com/SwapnilSoni1999/spotify-dl/pull/162
but not a big deal if you think the png 100% solves the problem we can just ditch this pr
Oh there is one thing i remeber about using ffmpeg if the the image is corrupt the flow will be killed so i think there needs to be a catch from memory, you should be able to test it by hardcoding a bad image and passing that garbage straight into ffmpeg
there was also this pr i made to attempt to fix it, though its a more of "okay lets try again" might aswell chuck these changes in with yours if you want
#162
but not a big deal if you think the png 100% solves the problem we can just ditch this pr
Ohh, I see, I think that both PRs can work together, but because I'm very bad at this of git and I don't want to mess everything up trying to bring your PR to my fork, I'll wait until owner merges your PR and then work with it.
Oh there is one thing i remeber about using ffmpeg if the the image is corrupt the flow will be killed so i think there needs to be a catch from memory, you should be able to test it by hardcoding a bad image and passing that garbage straight into ffmpeg
Yes, that's a good idea that I'll do when combining our PRs.
Should I convert this PR to a draft??
feel free to just copy paste my changes i dont need credit :)
it should be fine the maintainer can take a while to get to prs
👍 ill give it a test this afternoon
@phyzical It was probably that not all images were on the same format, and saving them as jpg caused weird things
Just give a look to conflicts please Will merge afterwards extremely sorry for being late My life is done nowdays Maybe will transfer my whole git to somebody I dont feel like doing anything
Will merge afterwards extremely sorry for being late
Don't worry about being late.
Just give a look to conflicts please
They should be solved now
awesome will publish by tomorrow