avrora

avrora copied to clipboard

Would you be open to a contribution adding telemetry (https://github.com/beam-telemetry/telemetry) support to this library? It'd be nice to have telemetry data for the following events:

• HTTP requests to the schema registry server
• Message encode
• Message decoding
• Schema encoding
• Schema decoding

I should be able to make a contribution if this is desired.

Hi @Stratus3D, it's a cool idea. I would appreciate your help.

Unfortunately, I'm not dog-flooding with this project anymore, I'm very concerned about any performance regressions and unnecessary dependencies.

~So it would be cool if telemetry would be an optional dependency we could plug in instead of adding it as a base dependency to the project. I'm very open to discussing and collaborating on how we would do it the easiest way.~

~As a starting point, we can discuss the draft.~

@Stratus3D I've read one more time what this lib provides and I think we can add it to the main dependencies to produce events 👍🏼

Hi @Strech , sorry for the late reply here. I was intending to use this as a dependency in a project I was working on but have since decided to stick with an existing avro library I've built on top of a few other packages. Since I'm not using avrora anymore adding telemetry support here is no longer a priority of mine. Do you want me to close this issue or leave it open for other contributors?

Thanks for the reply @Stratus3D, let's keep it, I will look into it and maybe add it myself.