Trevor Brown

Results 312 comments of Trevor Brown

I ended up solving this by doing something like this: ```elixir defmodule ClientImplementation do @behaviour Elasticsearch.API ... @impl true def request(config, method, url, data, opts) do # perform actual request...

I'd be happy to test this on my M1, but I need detailed steps in order to test it. > On an M1 machine, try to run npm ci on...

> Before we introduce changes like these I would like to standardize and have in our CI pipelines performance testing and reporting to PRs. For the record I agree with...

> Big question before we merge, is this considered a "breaking change"? I guess I never answered your question yesterday. Yes, I'd consider this a breaking change just to be...

> 1. Check $PWD/.tool-versions to see if there are any versions who don't have a corresponding plugin installed on the system. If there are any versions without a corresponding plugin,...

Thanks @chrisjpalmer! just scanned through the code and left some comments. I see our build is broken here, but it isn't due to your changes. I'll see about fixing it...

I think @gabrielsoldani makes some very good points about this. While I don't feel to strongly one way or the other, I think I'm more in favor of prepending by...

This is a good request. I'm not sure how many will want this, but I think it's something we should support. I have a couple thoughts about this: * I...

The `plugin-test` command installs the plugin in the same way a user would - by running same code that the `asdf plugin-add ` command invokes (see https://github.com/asdf-vm/asdf/blob/master/lib/commands/command-plugin-test.bash#L77). I'm not sure...