streets-gl icon indicating copy to clipboard operation
streets-gl copied to clipboard
verified publisher icon StrandedKitty

Dedicated building types

Open Matthias84 opened this issue 2 years ago • 9 comments

Hi,

I would ask if its possible to add nice specific defaults for buildings that only have a building type, but nothing set for roof and levels or material?

I suggest:

  • garage
  • garages
  • barn / farm_auxiliary / stable
  • bungalow / cabin
  • detached / semiattached
  • greenhouse
  • residential
  • riding_hall
  • sports_hall
  • stadium
  • hangar
  • parking
  • service
  • roof (esp. for fuel stations)

Matthias84 avatar May 04 '23 09:05 Matthias84

Honestly, I think anything more than changing the style of windows etc shouldn't be inferred. having things appear as blank boxes incentivises mappers to add the correct tagging

hb0nd avatar May 15 '23 18:05 hb0nd

Yes but the discussion of implicite vs. explicite is pretty old on OSM side and both side have pretty good arguments for it's position.

My idea was esp. to remove windows for service like buildings (garages, ...) to increase the plausibility. This is how osm2world does it since years. Maybe some default materials would be nice, but I agree that its hard to find global common appearance esp. between continents ...

Matthias84 avatar May 16 '23 16:05 Matthias84

Yeah, windows should be drawn only on appropriate building types! Or a tag was needed to describe whether a building or building:part has windows or not.

artus70 avatar May 17 '23 11:05 artus70

Or a tag was needed to describe whether a building or building:part has windows or not.

window=no should be already supported

ivanbranco avatar May 17 '23 11:05 ivanbranco

window=no should be already supported

This is great, thanks! Is this documented anywhere?

artus70 avatar May 17 '23 12:05 artus70

window=no should be already supported

This is great, thanks! Is this documented anywhere?

https://wiki.openstreetmap.org/wiki/Key:window

HolgerJeromin avatar May 17 '23 13:05 HolgerJeromin

Windows are already excluded from certain building types (but is overridden with explicit tagging):

https://github.com/StrandedKitty/streets-gl/blob/cd53e4ef7c93cb80e08344ae12d6163bcb16229c/src/lib/tile-processing/vector/qualifiers/factories/helpers/isBuildingHasWindows.ts#L1-L20

hb0nd avatar May 17 '23 14:05 hb0nd

@HolgerJeromin and @endim8: Very cool, thanks for the hints!

@endim8 One could discuss whether building=yes or building:part=yes should be drawn w/o windows, too.

artus70 avatar May 17 '23 14:05 artus70

Any chance how e.g. greenhouse could become a default glass material? :thinking:

Matthias84 avatar May 18 '23 12:05 Matthias84