SteelPhase

Results 29 comments of SteelPhase

I know there are a few issues open, but outside of that is there really any changes that need to be made?

I have a real hacky work around right now ```bash if [[ ! -z VSCODE_IPC_HOOK_CLI ]]; then REMOTE_CODE_BIN_PATH=$(echo $PATH | tr ':' '\n' | grep "/Users/steelphase/.vscode-server/bin/.*/bin") if [[ -d $REMOTE_CODE_BIN_PATH...

I stated that in my initial comment. VSCode is installed on the target system, and I executed `Shell Command: Install 'code' command in path` for it on the target system....

That is incorrect. `/usr/local/bin` is added to the path by `/etc/profile` when `/usr/libexec/path_helper` is executed. `path_helper` reads `/etc/paths` and `/etc/paths.d` to build a `PATH` environment variable. Current versions of macOS...

I'm not sure how vscode sets the path when connecting to a remote, and i'm assuming it's not public. I'd assume that there would need to be a step after...

My janky little hack above has solved this in the mean time. Maybe this is just going to be a bug in this specific scenario. I don't know how many...

I malformed the close message in #26. This can be closed

Sure, I have an example, based off of the idea [here](https://github.com/uber-go/zap/issues/557#issuecomment-380631868). This is just a rough example of how i'd use it. Probably worth handling the `!ok` moments as actual...

So about that. I don't even think json marshalling functions today. I'm assuming EncoderConfig being marshallable as JSON is left over from a point when it would actually work. I'm...

I see that now. Though it seems not well implemented. It can't unmarshal custom encoders for any of those values, it just uses the switch default value instead.