steamdb.info-issues icon indicating copy to clipboard operation
steamdb.info-issues copied to clipboard

Show only games of my library in the instant search

Open roberto-naharro opened this issue 7 years ago • 12 comments

This is a feature request to add an option in the left menu to show only the games you already have and check metacritic scores and information about your library in one sight.

roberto-naharro avatar Nov 16 '17 20:11 roberto-naharro

I added my +1. It could also be interesting to later expand it to search trough another profile's library, or specify more than one library to filter with (it could show the common games in a group, for instance, or just someone else's games). The opposite would be nice to have as well: "not in library".

MayeulC avatar Sep 20 '18 20:09 MayeulC

they still didnt add this feature...

tskxz avatar Nov 09 '20 09:11 tskxz

Doesn't this issue belong to the web extension? Anyway, I agree it would really be nice to use collection filters, such as owned/unowned/ignored/wishlisted.

Revadike avatar Apr 27 '21 19:04 Revadike

Doesn't this issue belong to the web extension?

This is a site feature.

These filters are hard to do efficiently, because your browser would have to keep requesting pages from Algolia until it can fill a screen (we can't upload what you own to Algolia for filtering).

xPaw avatar Apr 27 '21 19:04 xPaw

How well does Algolia handle thousands of filters?

Revadike avatar Apr 27 '21 19:04 Revadike

How well does Algolia handle thousands of filters?

I am not going to put your entire game list into every request.

xPaw avatar Apr 27 '21 19:04 xPaw

When you are doing any search request, there is an icon indicating a game is in your library. There is a request to check your library for sure, I think the solution could be filter the games that doesn't have this mark

roberto-naharro avatar Jun 22 '21 08:06 roberto-naharro

When you are doing any search request, there is an icon indicating a game is in your library. There is a request to check your library for sure, I think the solution could be filter the games that doesn't have this mark

Well that's not done by the agorlia backend, but on the clientside in instantsearch.js:

 return window.SteamDB.OwnedApps.has(n) ? e.ownClass = "owned" : window.SteamDB.WishedApps.has(n) && (e.ownClass = "wished"),

So, you could technically just hide the results you don't want, but that may lead to empty pages or at the very least very inconsistent pages of search results.

Revadike avatar Jun 22 '21 10:06 Revadike

I see. Could you request more pages from the backend module until you have enough results to format them in the frontend?

roberto-naharro avatar Jun 22 '21 12:06 roberto-naharro

I see. Could you request more pages from the backend module until you have enough results to format them in the frontend?

I think you can, but I also believe that defeats the purpose of using this search engine. Ultimately, it's up to @xPaw.

Revadike avatar Jun 22 '21 13:06 Revadike

maybe there is another way... could you do the search sending all the games ids from the frontend and filter in the backend? with some libraries it could be a little overkill, but you do less request in the end

roberto-naharro avatar Jun 22 '21 13:06 roberto-naharro

oh, I have just seen @xPaw response https://github.com/SteamDatabase/steamdb.info-issues/issues/533#issuecomment-827856429 forget about it haha

roberto-naharro avatar Jun 22 '21 13:06 roberto-naharro