chef-stackstorm icon indicating copy to clipboard operation
chef-stackstorm copied to clipboard

Remove `--always-copy` >=EL7

Open punkrokk opened this issue 5 years ago • 2 comments

The below two files needs the virtualenv_opts = --always-copy line either commented out or the value removed.

This needs validation. If https://github.com/StackStorm/st2/pull/4891 is merged, we can assume it's a go.

https://github.com/StackStorm/chef-stackstorm/blob/2aa543bbb19df1c176299aea22828d7a6e6e41a6/spec/recipes/config_spec.rb#L30-L32

https://github.com/StackStorm/chef-stackstorm/blob/2aa543bbb19df1c176299aea22828d7a6e6e41a6/spec/recipes/config_spec.rb#L30:L32

punkrokk avatar Mar 21 '20 04:03 punkrokk

A little bit more context.

Per https://github.com/StackStorm/st2/pull/4891 note that --always-copy flag should be removed for both EL7 and EL8 as it breaks virtualenv for pack install in these systems. However should exist for all other systems: currently EL6, U14, U16, U18.

This virtualenv_opts adjustment is automatically done by the packaging, however applying and templating custom st2.conf as it's done in chef-stackstorm breaks it.

cc @nmaludy Please check if there is a similar issue with the Puppet module or whether st2.conf templating happens there too.

arm4b avatar Mar 22 '20 14:03 arm4b

@armab Doesn't appear to be an issue in the Puppet module. In Puppet we use the ini_setting resource and edit individual pieces instead of templating the whole file (for now).

nmaludy avatar Mar 23 '20 11:03 nmaludy