Simon Marquis
Simon Marquis
Not sure why exactly, but reverting this commit https://github.com/mockk/mockk/pull/1145/commits/fc4b0c5d0a87d131acfb9fc4f0ff193205ad6678 seems to make this test pass correctly (although `JvmMockKProxyMakerTest#garbageCollectedProxy()` now fails with `MockKAgentException: Value for this result is not assigned`)
âšī¸ Running the default `gradlew :app:generateProdReleaseBaselineProfile` task leads run a Gradle error where it says the target app is not installed on the device đ¤¯ I would have thought the...
@keyboardsurfer can you share with us what is the expected run configuration for this project? **BuildType/Flavor:** - `ProdRelease`: unable to reproduce since production API keys are not provided here (although...
Although the `BaselineProfileGenerator` test succeeded, I got the following error: ``` FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':benchmarks:collectDemoNonMinifiedReleaseBaselineProfile'. > kotlin.io.NoSuchFileException: nowinandroid\benchmarks\build\intermediates\managed_device_android_test_additional_output\demoNonMinifiedRelease\pixel6api31aospDemoNonMinifiedReleaseAndroidTest\BaselineProfileGenerator_generate-baseline-prof-2023-07-28-19-46-26.txt: The...
I guess you made huge progress on #880 making this PR a bit outdated đ
đ should we close this issue? Hey @LouisCAD, the team decided not to move forward with this feature _Originally posted by @mmoczkowski in https://github.com/android/nowinandroid/issues/455#issuecomment-1326461091_
What would be the appropriate style? https://github.com/android/nowinandroid/blob/e72e31b1f013676a10b4ecc6f83606a51141e862/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt#L270-L272 `MaterialTheme.typography.bodyMedium` maybe?
| Default | `bodySmall` | `bodyMedium` | `bodyLarge` | |---|---|---|---| |  |  |  |  |
Though it seems like the `NiaFilledButton` (and `NiaOutlinedButton`) are always using `MaterialTheme.typography.labelSmall` without checking the value of the boolean parameter `small`. https://github.com/android/nowinandroid/blob/e72e31b1f013676a10b4ecc6f83606a51141e862/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/Button.kt#L73-L77 Maybe the better fix would be to do:...
@dturner this has been fixed, you can close the issue :) 