Do not go through all directory files when bumping

Open Morriar opened this issue 3 years ago • 2 comments

Closes #127.

Before this patch, we were listing, reading and checking all the files (direct and in subdirs) we could find from the bump directory. This may be highly inefficient, especially when the directory contains a lot of files that will end up ignored from the Sorbet config.

After this patch, while we still list them all, we at least do not read and check them if they get ignored by the config.

Apr 12 '22 22:04 Morriar

@Morriar Just cleaning through our PRs: Can we merge this one?

Jun 15 '22 13:06 wildmaples

No, as pointed in the issue it only moved the problem. I'll have to find a smarter way.

Jun 15 '22 15:06 Morriar

Superseded by https://github.com/Shopify/spoom/pull/322.

Mar 22 '23 22:03 Morriar