Yuan Wang

Results 97 comments of Yuan Wang

from POV of `PEL`, returning -1 means `ID not found in the stream`, other values ​​mean PEL ACK is successful from POV of entry: if we use `0` and `1`,...

generally LGTM now, cc @sundb have a look

could you please trigger a fully CI in your repo

resolved by https://github.com/redis/redis/pull/13798

reopen, since https://github.com/redis/redis/pull/13798 is to set fields expire time instead of key itself

@luorong1999 i still don't understand your scenarios, after converting this key into an integer, you can make it easy to compare objects? I think it’s best that we don’t do...

I think it would be better to check it, maybe you can make a PR

For `IOThreadReplicationCron` for master client, maybe it is not necessary, the master send `PING` every second, and now we have `IOThreadClientsCron` that can send all clients to main thread for...

> Then it remains in IO-thread until it reads ACK and is then send to main thread. I think this method may cause a delay for replication cron, an extra...