James Sherlock

Results 152 comments of James Sherlock

Thanks Lukasa, I can confirm that moving my code onto a background thread has at least silenced the warning.

> Hey @Sherlouk I am facing the same issue. Can you show me the piece of code how you moved your code in background thread as an example? Simply the...

![image](https://user-images.githubusercontent.com/15193942/182387246-73abf4f6-c4b9-4bb2-b690-9ae76efa6933.png) Not pretending it's clean, but by modifying your `main.swift` file you can get JMH output without too much effort. As an MVP: ```swift import Benchmark import Foundation var runner...

Unfortunately I did dump "env" into a file and compared and there was only one difference to a "deep analysis" variable which feels weak to rely on. The schema doesn't...

Sorry for delay, opened PR.

No worries! It's already on the main SnapshotTesting README, and doesn't depend on this project (though are related in theme) - it's probably fine as it is for now 🙂

Is this still needed Daniel? I assume this means renaming away from "TelemetryClient"?

Would certainly be a breaking change, and so would be best to wait until there are other technical reasons for wanting to release a v2.0.0. Perhaps worth setting up a...

Hey Reda. Pedro asked a really valuable question in the initial pitch: > Is it possible to use [this custom URLSession](https://github.com/meilisearch/meilisearch-swift/blob/master/Sources/MeiliSearch/Config.swift#L61) from the Config initializer In fact, this is the...