Seth Morton

Results 75 comments of Seth Morton

A few more thoughts - I notice now that distclean.cmake is gone. Is there equivalent functionality from cmake itself? - The code to set up things like LAPACK, OpenMP, and...

- Make sense, if everything is in `build` the cleanup is simple. Looking at the content of that file, it seems like CMake used to put `CMakeCahce.txt`, `cmake_install.cmake`, `install_manifest.txt`, and...

- We should add protection that prevents users from doing an in-source build. I think in my original template I allowed that, which was why the `distclean.cmake` was needed. -...

OK, so I see that elsewhere (https://mirkokiefer.com/cmake-by-example-f95eb47d45b1) folks are advocating for the `make; make install` idom as you do, and they advocate to use `-DCMAKE_INSTALL_PREFIX=blah` when invoking `cmake` initially to...

Are the config files you added VS code-specific, or can they work for other editors? If the template is going to comprehend editor configurations, it should probably do so for...

@emanspeaks I am currently on paternity leave, so have time to get this done. Shoot me an email and let's work to get this released soon.

If the `SET_COMPILE_FLAG` function is called with the `REQUIRED` option, then it will fail if no valid flags are found. In the template, the only calls with `REQUIRED` are the...

Is there a reason you didn't modify `SetCompileFlag.cmake` with the message the `pgfortran` was giving on compile error? I believe that would have been less work.

The string "No such file or directory" could be added to the `FAIL_REGEX` in `SetCompileFlag.cmake` to solve the problem. I am glad you have a solution that works for you....

@emanspeaks Based on your willingness to tackle #3 I would guess you are actually versed in modern CMake style. I don't think there are many out there that have that...