sigmastate-interpreter icon indicating copy to clipboard operation
sigmastate-interpreter copied to clipboard

Published 20 hours ago • verified publisher icon ScorexFoundation

[v6.0] Accumulate ErgoTree deserialization cost

Open sethdusek opened this issue 1 year ago • 6 comments

For #846

I've accumulated the deserialization cost into the total cost and updated all the relevant test cases with costs for all ErgoTree versions when V3 is activated.

sethdusek avatar Nov 22 '23 04:11 sethdusek

Should I rebase this to #930?

Also are there any formatting guidelines? There doesn't seem to be any mention of proper formatting in CONTRIBUTING.md.

sethdusek avatar Nov 23 '23 06:11 sethdusek

CI should be good to go now! Added new version tests for V3, please take a look at those as well

sethdusek avatar Dec 21 '23 17:12 sethdusek

Please re-run CI, I believe this CI failure was due to an issue in the underlying branch and not this PR itself. Github doesn't seem to automatically re-run CI for PRs when the base branch changes

sethdusek avatar Jan 19 '24 19:01 sethdusek

Github doesn't seem to automatically re-run CI for PRs when the base branch changes

@SethDusek, yes, because changing the base branch doesn't change the commit which is tested. Also, "re-run" command in somehow not available in the logs.

aslesarenko avatar Jan 22 '24 14:01 aslesarenko

Indeed, ErgoTreeSerializerSpecification is failing, which is unlikely touched by this PR and locally tests are passed

kushti avatar Jan 31 '24 12:01 kushti

@aslesarenko please review

kushti avatar Jan 31 '24 12:01 kushti