iris

iris copied to clipboard

🚀 Pull Request

Description

Use the iris optimal chunk size algorithm to set reasonable chunk sizes for derived coordinates.

This is one way to solve #5457.

Could I have some feedback on the approach, please? See also the question in the issue.

Consult Iris pull request check list

Jan 24 '24 15:01 bouweandela

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.71%. Comparing base (adca725) to head (963eceb). Report is 101 commits behind head on main.

@@           Coverage Diff           @@
##             main    #5712   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          90       90           
  Lines       22816    22830   +14     
  Branches     5438     5442    +4     
=======================================
+ Hits        20469    20483   +14     
  Misses       1617     1617           
  Partials      730      730           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jan 24 '24 15:01 codecov[bot]

@bouweandela please could we try an alternative solution that changes the chunking of the original coordinates (the ones that make up the derived coordinate)? We know that users could override this using CHUNK_CONTROL if they wanted.

Thanks 😊

Feb 29 '24 13:02 trexfeathers