iris icon indicating copy to clipboard operation
iris copied to clipboard

Published 20 hours ago • verified publisher icon SciTools

New LBFC-CF mappings

Open trexfeathers opened this issue 3 years ago • 2 comments

🚀 Pull Request

Linked: SciTools/iris-grib#297 - Julian Heming is aiming for some additional GRIB-to-PP mappings.

I was able to confirm Julian's suggested STASH-LBFC mappings via the Met Office Codes Registry. We had all the referenced STASH codes in Iris, but were missing some of the LBFC codes.

This is fresh territory for me so I'm not 100% confident. Please can the reviewer be vigilant!

I also need Julian's eyes on this before merging. I don't think he's on GitHub but I will be contacting personally.

Julian: I have not included the following from your suggestion, since they were not in the Met Office Codes Registry:

  • Shear vorticity - m01s20i101, LBFC 1112
  • Curvature vorticity - m01s20i102, LBFC 1113

Consult Iris pull request check list

trexfeathers avatar Jul 11 '22 17:07 trexfeathers

~~To do: what's new entry~~

trexfeathers avatar Jul 11 '22 17:07 trexfeathers

I expect these mappings are all fine. To avoid staleness I propose reviewing and merging at the end of September.

trexfeathers avatar Sep 20 '22 10:09 trexfeathers

Julian has approved this as working for their tests 👍

trexfeathers avatar Oct 04 '22 09:10 trexfeathers