HVScrollView icon indicating copy to clipboard operation
HVScrollView copied to clipboard

It looks like they removed support for GHE with version 0.16.

Open jkidd11 opened this issue 3 years ago • 0 comments

It looks like they removed support for GHE with version 0.16.

It took me a bit of digging, and it doesn't look like there was any notification that this support was going away - but I don't pay close attention to the issues here.

I'm personally a bit confused about the reasoning (that they don't have resources to test against it). Especially since they appear to be using Octokit.rest which has first class support for GHE out of the box.

Originally posted by @GABeech in https://github.com/microsoft/vscode-pull-request-github/issues/1793#issuecomment-627414944

jkidd11 avatar May 24 '22 21:05 jkidd11

I've updated my branch to the newest develop, which in the meantime has switched to header-only .. tests are passing on my machine

Sidelobe avatar May 06 '20 10:05 Sidelobe

Any chance of this getting merged?

Sidelobe avatar Jun 17 '20 14:06 Sidelobe

Sorry I haven't been able to take a look at this yet - I will do that in the next few days, thanks for contributing! :)

Adam

adamstark avatar Jun 17 '20 20:06 adamstark

Got stuck into it right now - I've just merged it in. Thanks again! :)

I'll need to catch up on this to get it pushed to master, will try and do that over the next couple of days as i need to review some other new features on develop.

Adam

adamstark avatar Jun 17 '20 20:06 adamstark

BTW, what can I use to test / open / edit 8 channel WAV files? This was one of the big blockers for me :)

adamstark avatar Jun 17 '20 20:06 adamstark

Awesome, thanks Adam!

To quickly create/edit multichannel wave files, I use Audacity -- ugly interface, but extremely powerful :-) https://www.audacityteam.org/

Sidelobe avatar Jun 18 '20 06:06 Sidelobe