SORMAS-Project icon indicating copy to clipboard operation
SORMAS-Project copied to clipboard

Published 20 hours ago • verified publisher icon SORMAS-Foundation

Bugfix 10343 missing validations via api

Open andrei7bal opened this issue 3 years ago • 1 comments

#10343 Add new validations for required fields when adding data from API

  • add new validations for Sample and for TravelEntry
  • use @NotEmpty annotation instead of @Requried (it's gonna be deprecated)

andrei7bal avatar Sep 17 '22 13:09 andrei7bal

Hello @JonasCir I've commited the changes. Please note that for the @Required annotation refactoring, there will be a new ticket (as I was suggested), so for this Pull Request only PointOfEntryDetails (TravelEntryDto) and SampleMaterialText (SampleDto) are treated. Thanks for looking into this.

andrei7bal avatar Sep 21 '22 14:09 andrei7bal

hey, take a look at the issue again: The second scenario is not fixed.

JonasCir avatar Sep 22 '22 13:09 JonasCir

tests are failing now

JonasCir avatar Sep 22 '22 14:09 JonasCir