RSA icon indicating copy to clipboard operation
RSA copied to clipboard

Implement verify-only PSS PaddingScheme

Open lumag opened this issue 3 years ago • 2 comments

A fix for #172 , implementation of verify-only PSS padding schema

lumag avatar Jul 31 '22 09:07 lumag

Instead of introducing a DummyRng, it seems to me like it would make more sense to remove salt_rng from PaddingScheme::PSS.

Its only use is to pass it to pss::sign, and in that regard it can be passed as an explicit parameter rather than embedding it into the padding scheme. An RNG is already an explicit parameter to sign_blinded (in which case it receives two RNGs. I'm not sure why one would want to use two RNGs?)

Really it'd be nice to implement the traits from the signature crate, where the "sign" vs "sign with RNG" cases are concretely handled as Signer versus RandomizedSigner, but that's a lot more work.

tarcieri avatar Jul 31 '22 12:07 tarcieri

@tarcieri done

lumag avatar Jul 31 '22 13:07 lumag

gracious ping

lumag avatar Aug 17 '22 19:08 lumag

Refreshed to remove conflict.

lumag avatar Aug 23 '22 07:08 lumag

@tarcieri could this be included in the upcoming 0.7.0 release? It would save me a dependency and make it clearer what is going on in my code.

Kriskras99 avatar Sep 14 '22 15:09 Kriskras99

Yep, that's the plan

tarcieri avatar Sep 14 '22 16:09 tarcieri

Yep, that's the plan

Great! I look forward to testing 0.7.0-pre2😁

Kriskras99 avatar Sep 14 '22 22:09 Kriskras99