Matt

@ariG23498 Yes, correct! When you `self.add_weight()` in `build()` then you don't need to define an extra name scope with the same name.

Hi @ariG23498, we're almost there! I just ran the doctests and there's a couple of small failures, but it should just be small stuff like missing return values in the...

Looks clean to me now! Is there anything else you want to finish up, or are you happy for me to merge it?

@ydshieh I'm sorry!! Trying it now!

@ydshieh Do you know why some of the torch tests fail in the slow CI for Mistral even though they pass in the nightly tests?

Yes, that's what I was referring to - and I think it's fine to keep it as-is!

@molbap I didn't see your PR, but we should definitely use your approach! Supporting chat templates should be simple enough - all they require is moving `apply_chat_template` to `ProcessorMixin`, and...

Cool! I'll probably wait until yours is merged, in that case, and then adding chat templates should be clean and straightforward.

Hi @fabiancpl, Python 3.13 was very recently released in beta, and many packages won't work properly with it! I think that's the most likely cause of the issue here, especially...

cc @lewtun and @xenova to this as well!