RocketPy icon indicating copy to clipboard operation
RocketPy copied to clipboard

eliminating multiple plots for inertia tensors

Open dipesh2212 opened this issue 1 year ago • 1 comments

Pull request type

  • [ ] Code changes (bugfix, features)

Checklist

Current behavior

There are multiple inertial tensor plots that are being plotted, it is kinda annoying to deal with those

New behavior

I've tried to integrate all the plots in one single plot which can compare the inertia tensor in a convenient way

Breaking change

  • [ ] No

dipesh2212 avatar Feb 29 '24 21:02 dipesh2212

I'm still investigating the reason, but I got this error when running my_solid_motor_example.all_info():

image

Gui-FernandesBR avatar Feb 29 '24 21:02 Gui-FernandesBR

A quick update in the function:

image

I'm getting this result: image

Gui-FernandesBR avatar May 30 '24 21:05 Gui-FernandesBR

Here is the final result:

image

Gui-FernandesBR avatar Jun 29 '24 22:06 Gui-FernandesBR

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (622ae81) to head (cd883da). Report is 1 commits behind head on develop.

:exclamation: Current head cd883da differs from pull request most recent head 5c8e11a

Please upload reports for the commit 5c8e11a to get more accurate results.

Files Patch % Lines
rocketpy/plots/motor_plots.py 84.21% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #566      +/-   ##
===========================================
- Coverage    71.92%   71.86%   -0.07%     
===========================================
  Files           70       70              
  Lines        10334    10320      -14     
===========================================
- Hits          7433     7416      -17     
- Misses        2901     2904       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 29 '24 22:06 codecov[bot]