RocketPy icon indicating copy to clipboard operation
RocketPy copied to clipboard

Published 20 hours ago • verified publisher icon RocketPy-Team

MNT: delete tools.cached_property (fix #531)

Open dyu056 opened this issue 1 year ago • 4 comments

Pull request type

  • [ v] Code changes (bugfix, features)

Checklist

  • [ v] Tests for the changes have been added (if needed)
  • [ v] Docs have been reviewed and added / updated
  • [ v] Lint (black rocketpy/ tests/) has passed locally
  • [ v] All tests (pytest --runslow) have passed locally

Current behavior

Issue 531, current behavior doesn't change too much

New behavior

Issue 531, current behavior doesn't change too much

Breaking change

  • [ ] Yes
  • [ v] No

Additional information

Enter text here...

dyu056 avatar Jan 25 '24 22:01 dyu056

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d86c760) 71.23% compared to head (397ec38) 71.21%. Report is 1 commits behind head on master.

Files Patch % Lines
rocketpy/environment/environment_analysis.py 50.00% 2 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   71.23%   71.21%   -0.03%     
==========================================
  Files          55       55              
  Lines        9259     9242      -17     
==========================================
- Hits         6596     6582      -14     
+ Misses       2663     2660       -3
Flag Coverage Δ
unittests 71.21% <60.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 25 '24 23:01 codecov[bot]

This PR is trying to merge directly into the master branch. This needs to be changed to merge into develop instead.

I think the easiest solution is the cherry picking now: https://stackoverflow.com/questions/36055622/how-to-change-base-branch-in-git

It's important to follow the git flow correctly so we an easily navigate through our git tree in the future. Therefore, only hotfixes and releases should be merged directly to the master branch. New features needs to pass through the develop one.

Gui-FernandesBR avatar Jan 30 '24 16:01 Gui-FernandesBR

This PR is trying to merge directly into the master branch. This needs to be changed to merge into develop instead.

I think the easiest solution is the cherry picking now: https://stackoverflow.com/questions/36055622/how-to-change-base-branch-in-git

It's important to follow the git flow correctly so we an easily navigate through our git tree in the future. Therefore, only hotfixes and releases should be merged directly to the master branch. New features needs to pass through the develop one.

Gui-FernandesBR avatar Jan 30 '24 16:01 Gui-FernandesBR

Renamed the PR to make it easier for us.

Gui-FernandesBR avatar Feb 12 '24 07:02 Gui-FernandesBR