RocketPy ENH: _check_user_input method being called multiple times

ENH: _check_user_input method being called multiple times

Open lucasfourier opened this issue 1 year ago • 2 comments

Describe the bug

The _check_user_input method is being called multiple times for some unexpected reason during init for the same source file.

Expected behavior

Processing should not result in redundant calculations and function calls.

Additional context

This discussion arised from a hotfix. For additional information, one should read the following: https://github.com/RocketPy-Team/RocketPy/pull/478

Nov 23 '23 02:11 lucasfourier

I'm not sure if this is a bug, it was exactly what was intended. An optimization is more than welcome tho, calling it multiple times is a bad idea.

Nov 23 '23 14:11 Gui-FernandesBR

True. Changing the label.

Nov 23 '23 14:11 lucasfourier