RocketPy icon indicating copy to clipboard operation
RocketPy copied to clipboard

Published 20 hours ago • verified publisher icon RocketPy-Team

BUG: Motor.export_eng doesn't work for liquid motors

Open Gui-FernandesBR opened this issue 1 year ago • 1 comments

Describe the bug

Take a look the method's definition. As the liquid motors do not have propellant grains, this method will fail.

To Reproduce

Create a liquid motor and try to export its data using export_eng method

Expected behavior

  • We should refactor this method and ensure that it work for
  • We should also create unit tests to prevent this behavior to happen again (please include all the types of motor in this test, even the GenericMotor)

Screenshots

image

Gui-FernandesBR avatar Nov 20 '23 02:11 Gui-FernandesBR

Working on it right now

lucasfourier avatar Feb 18 '24 20:02 lucasfourier