Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

Published 20 hours ago • verified publisher icon RocketChat

[NEW] EmojiPicker with searching functionality

Open try-catch-stack opened this issue 3 years ago • 4 comments

Proposed changes

  • Migrated EmojiPicker to hooks.
  • Revamped EmojiPicker component. Added functionality to search and delete emojis.

Issue(s)

How to test or reproduce

Screenshots

Before After
emoji-picker-before1 new emoji-picker-after1
emoji-picker-before2 emoji-picker-after2
reaction-picker-before reaction-picker-after1

  • Searching emojis:

reaction-picker-after2 reaction-picker-search

https://user-images.githubusercontent.com/77742477/179019484-7d9cec0e-30ba-494b-9e94-78c846931d97.mp4

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] Improvement (non-breaking change which improves a current function)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [X] I have read the CONTRIBUTING doc
  • [X] I have signed the CLA
  • [X] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

try-catch-stack avatar Jun 28 '22 15:06 try-catch-stack

errors: When you send an emoji the keyboard does not close automatically. When clicking directly on the emoji without clicking on the keyboard, when I switch to keyboard it doesn't work, the keyboard is black.

I believe, this issue should now be fixed.

try-catch-stack avatar Jul 30 '22 11:07 try-catch-stack

This pull request introduces 5 alerts when merging fc0817446d9113b595b4b3d63968f07368a84c84 into 300e5fc7931d8045f1835f91ef10960661ee4003 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 11 '22 18:10 lgtm-com[bot]

This pull request introduces 3 alerts when merging fbf82de6bf11cee87dfc375ad1a4b7b5b3d8742b into 300e5fc7931d8045f1835f91ef10960661ee4003 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 13 '22 18:10 lgtm-com[bot]

This pull request introduces 1 alert when merging e0ce95e9e1161d0f70532dd953bcb1892b4af369 into 761aef2c045246c52a07c0048f803441146ae188 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 18 '22 20:10 lgtm-com[bot]

Screen Shot 2022-10-21 at 10 34 31 When I didn't send any emoji the most used emojis tab is showing empty (It shouldn't appear I think)

dnlsilva avatar Oct 21 '22 14:10 dnlsilva