Rocket.Chat.Apps-engine icon indicating copy to clipboard operation
Rocket.Chat.Apps-engine copied to clipboard

Adds SubscriptionRead and ISubscriptionBridge

Open marceloschmidt opened this issue 7 years ago • 3 comments

Implemented here: https://github.com/RocketChat/Rocket.Chat/pull/15549

marceloschmidt avatar Jul 31 '18 02:07 marceloschmidt

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 08 '19 12:10 CLAassistant

Codecov Report

Merging #43 into alpha will increase coverage by 1.99%. The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha      #43      +/-   ##
==========================================
+ Coverage   53.05%   55.04%   +1.99%     
==========================================
  Files          74       83       +9     
  Lines        2754     2885     +131     
  Branches      408      408              
==========================================
+ Hits         1461     1588     +127     
- Misses       1293     1297       +4     
Impacted Files Coverage Δ
src/server/bridges/AppBridges.ts 100.00% <ø> (ø)
src/server/bridges/index.ts 100.00% <ø> (ø)
src/server/compiler/AppCompiler.ts 26.03% <0.00%> (ø)
src/server/accessors/RoomSubscriptionRead.ts 33.33% <33.33%> (ø)
src/server/accessors/Reader.ts 100.00% <100.00%> (ø)
src/server/accessors/index.ts 100.00% <100.00%> (ø)
src/server/managers/AppAccessorManager.ts 100.00% <100.00%> (ø)
src/server/storage/index.ts 100.00% <0.00%> (ø)
src/server/compiler/index.ts 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3fe543...b83acd8. Read the comment docs.

codecov[bot] avatar Oct 08 '19 12:10 codecov[bot]

subscription-testing_0.0.12.zip

Here is the app to run to test. It simply logs the subscription's of a room to the logger (aka don't do it on a big room otherwise the logs will be filled).

graywolf336 avatar May 11 '20 15:05 graywolf336