Rocket.Chat.Apps-engine
Rocket.Chat.Apps-engine copied to clipboard
[IMPROVEMENT] Allow longer vm.runInContext timeout in debug mode
What? :boat:
It will use a different timeout (3600 * 1000 ms instead of 1000 ms) when you start a RocketChat instance with meteor npm run debug instead of meteor or meteor npm start. This change will make debugging workflow more convenient (such as adding breakpoints in the apps-engine or Rocket.Chat).
Why? :thinking:
Originally, if you add a breakpoint inside a RocketChat ap or apps-engine, it might throw an error since vm.runInContext timeout might be over 1000 ms. Thereby, it makes debugging difficult to be continued.
Links :earth_americas:
PS :eyes:
Codecov Report
Merging #340 into alpha will increase coverage by
1.88%. The diff coverage is0.00%.
@@ Coverage Diff @@
## alpha #340 +/- ##
==========================================
+ Coverage 50.69% 52.58% +1.88%
==========================================
Files 75 83 +8
Lines 2858 2980 +122
Branches 436 437 +1
==========================================
+ Hits 1449 1567 +118
- Misses 1409 1413 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/server/ProxiedApp.ts | 13.48% <0.00%> (-0.64%) |
:arrow_down: |
| src/server/marketplace/license/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/storage/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/errors/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/compiler/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/managers/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/bridges/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/accessors/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/logging/index.ts | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 000e42d...a14cdb8. Read the comment docs.