The Current Stable Version for typescript is version 3.6.3 so updated typescript to latest version solves #107

All committers have signed the CLA.

@ashu8912 have you tested that this works with the Rocket.Chat implementation and the compiling of Apps at runtime? Please report back when you have as I have a feeling something might break with updating due to how we interact with typescript's internals.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7db6e7c). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #146   +/-   ##
========================================
  Coverage          ?   55.4%           
========================================
  Files             ?      68           
  Lines             ?    2397           
  Branches          ?     360           
========================================
  Hits              ?    1328           
  Misses            ?    1069           
  Partials          ?       0

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7db6e7c...cdea38f. Read the comment docs.

hey @graywolf336 Yes There were some errors after updating typescript version to the latest But I have solved them now.The Solution was to add in another dependency @types/node and it did fixed everything. All the unit tests pass now as well as there are no errors on compilation.

And how does this work when inside of Rocket.Chat? Can you install an app and it run just fine?

Hi guys, I'm very interrested in this PR to be merged.

What I understand is the current state is that it only needs to be tested inside a Rocket.Chat instance ? Like installing an app containing specific TypeScript 3.x features and check that everything's right ?

If so, I volonteer to check this : if you have any suggestion, I'll take them.

Step one : clone the PR locally on my Rocket.Chat instance and see what's happening

Hi guys, I'm very interrested in this PR to be merged.

What I understand is the current state is that it only needs to be tested inside a Rocket.Chat instance ? Like installing an app containing specific TypeScript 3.x features and check that everything's right ?

If so, I volonteer to check this : if you have any suggestion, I'll take them.

Step one : clone the PR locally on my Rocket.Chat instance and see what's happening

Hello, @ThomasVuillaume ! Thanks for the attention. You can use git fetch origin pull/146/head:ts-version-3.6.3 && git checkout ts-version-3.6.3 to checkout this pr.

Hi guys, I did the tests and everything seems fine with TypeScript 3.8.3.

I made another pull request (#251)