laravel-tinker icon indicating copy to clipboard operation
laravel-tinker copied to clipboard

[Bug]: Strange or no output (on e.g. execeptions) on v2.7.0

Open marclangesauels opened this issue 1 year ago • 10 comments

Short bug description

No Output when an Exception occurs

Extended bug description

When the code you try to run produces an error no output is shown. This was not the case with the prevoius version (2.6.1) Screenshot 2024-04-11 134959

Your project is not the problem

  • [X] I tried using a fresh laravel install - I'm fairly certain it has nothing to do with my project.

How to reproduce?

tried provoking an error

Expected behavior

showing an exception message

Screenshots

image

IDE & Version

2024.1

PHP Version

8.2

OS and version

Windows 11

Laravel Tinker plugin version

2.7.0

Interpreter type

Docker compose

Laravel Version

9.52.16

Tinker version

2.9.0

Psysh version

0.12.2

Additional Context

No response

marclangesauels avatar Apr 11 '24 11:04 marclangesauels

Ah yes.. Exceptions.. I missed those - there's too much indivialual ways things get outputted :P. On it ;)

Roboroads avatar Apr 11 '24 15:04 Roboroads

Any update on this?

pindab0ter avatar Apr 17 '24 09:04 pindab0ter

Still working on it. Unsure why errors are outputted differently from the rest.

Roboroads avatar Apr 18 '24 12:04 Roboroads

The 26th I posted a question in the IntelliJ Slack; so far no answer.

Roboroads avatar Apr 30 '24 14:04 Roboroads

Thanks @Roboroads for your efforts. I am also waiting on a fix for this, which also I assume it will also fixes the #326 issue.

N-Molham avatar May 02 '24 06:05 N-Molham

I assume it will also fixes the #326 issue.

It will, yea. Sorry it's taking so long. I think the main guy that helps with PHP is on holiday.

Roboroads avatar May 02 '24 07:05 Roboroads

No worries @Roboroads, no need for apology. Appreciate the response and your efforts put into this plugin. It is a game changer for me

N-Molham avatar May 02 '24 07:05 N-Molham

Agreed, we really appreciate the effort you're putting into this! The extension has been so great for me. Beats going into the CLI and setting up your environment each time or using a dedicated tinkering route. I love being able to whip up a tinker session with a shortcut and just trying/verifying stuff.

We'd love for it to be fixed, but no need to apologise. I've had PRs merged four years after I've opened them barely any communication, so I'm used to much worse, haha.

pindab0ter avatar May 02 '24 07:05 pindab0ter

I'm getting weird output when tinkering:

print "Test";

Same issue?

mvdgeijn avatar May 06 '24 16:05 mvdgeijn

@mvdgeijn yes, it is. I'm seriously considering rolling back until I get a response from JetBrains.

Roboroads avatar May 06 '24 20:05 Roboroads

Not sure if it is related, @Roboroads, but for me the output will always be empty when exception was thrown somewhere, like here: image

zaalbarxx avatar May 23 '24 12:05 zaalbarxx

Until this is resolved, this is what I'm using in my Tinker Console to get by:


try {
    $result = 'Foo';
    
    dump($result);
} catch(Exception $exception) {
    dump($exception);
}

pindab0ter avatar May 23 '24 15:05 pindab0ter

Yeah, that's what I did :) Just making sure that the kind of issue I encountered is the same as the one from this isue :) Thanks anyway :) Cheers!

zaalbarxx avatar May 23 '24 15:05 zaalbarxx

Little update, JB has responded with "will take a look at it" - which has been 2 weeks ago. I'm getting to a point where I just want to rollback to 2.6 and then have people on windows deal with their Arabic/Cyrillic text issues for a while again..

Roboroads avatar Jun 14 '24 13:06 Roboroads

As a mac user, I'm up to it 😅

shina avatar Jun 17 '24 08:06 shina

I think it would be a good idea to make that decision based on the size of the impacted groups, for as far as you are able to determine that.

pindab0ter avatar Jun 17 '24 09:06 pindab0ter

Hi all. I decided to revert back to 2.6 way of handling output. Release is pending into 2.7.1 and will be available for download shortly. This does mean that I will have to reopen #255 for the time being. Sorry windows users husing arabic/cyrillic text :(

Roboroads avatar Jun 17 '24 15:06 Roboroads

Just got the update, I'm so happy that it's working as intended again! Thank you so much! 🙏

pindab0ter avatar Jun 19 '24 09:06 pindab0ter

Oh yea, forgot to update this. I figured it out :) It's fixed now ^^

Just got the update, I'm so happy that it's working as intended again! Thank you so much! 🙏

Y'er welcome! I'm very happy myself as well :joy:

Roboroads avatar Jun 19 '24 12:06 Roboroads