SIFU icon indicating copy to clipboard operation
SIFU copied to clipboard

Regarding the issue during testing

Open glorioushonor opened this issue 1 year ago • 1 comments

Hello, I would like to ask if it is not necessary to have the left and right normal maps of the SMPL model when testing with the CAPE dataset? I noticed that the dataset does not include them.

glorioushonor avatar Apr 24 '24 09:04 glorioushonor

Do you have a backtrace, or a way we can reproduce this? This doesn't strike me as a Trilogy bug, but tough to help further without more information.

composerinteralia avatar Nov 08 '23 14:11 composerinteralia

I experienced the same issue when used gem "activerecord-trilogy-adapter" in Rails 7.1 app (which does not need it and comes with built-in support for Trilogy).

zhuravel avatar Nov 15 '23 15:11 zhuravel

Ah, we should probably add a < 7.1 constraint on activerecord-trilogy-adapter.

composerinteralia avatar Nov 15 '23 15:11 composerinteralia

Unfortunately that'll just send Bundler to find the latest version that had the more open-ended dependency.

Best might be to explicitly check the Rails version and no-op in the Railtie?

matthewd avatar Nov 15 '23 17:11 matthewd

That's a good point. Yeah, either no-op or raise/deprecate with a message about removing the gem.

composerinteralia avatar Nov 15 '23 17:11 composerinteralia

Perhaps try using trilogy gem instead of activerecord-trilogy-adapter?

Rails v7.1+ includes Trilogy support by default making this gem unnecessary due as part of https://github.com/rails/rails/pull/47880.

I experienced the same issue when using this gem, and did not have the error once I switched over.

ravangen avatar Apr 15 '24 19:04 ravangen