go-oauth2-server icon indicating copy to clipboard operation
go-oauth2-server copied to clipboard

Crash inUSProjectileMovementComponent::Reset()

Open mss10001 opened this issue 1 year ago • 5 comments

Due to the pooling system you can get a crash in USProjectileMovementComponent::Reset(). We need to check with HasbeenInitialized() if the movement component is already initialized before initializating it again.

// Properly resets velocities and rotations if (HasBeenInitialized()) { UninitializeComponent(); }

InitializeComponent();

mss10001 avatar Dec 05 '23 09:12 mss10001

Thanks for reaching out!

Have you made sure the class you're working with has the Pooling Interface implemented?

On Tue, Dec 5, 2023, 9:45 a.m. mss10001 @.***> wrote:

Due to the pooling system you can get a crash in USProjectileMovementComponent::Reset(). We need to check with HasbeenInitialized() if the movement component is already initialized before initializating it again.

// Properly resets velocities and rotations if (HasBeenInitialized()) { UninitializeComponent(); }

InitializeComponent();

— Reply to this email directly, view it on GitHub https://github.com/tomlooman/ActionRoguelike/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQJCQNK5X4AMGYSUJECNIWTYH3UL7AVCNFSM6AAAAABAHL664GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDKNZXG42DANA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LairdWT avatar Dec 05 '23 12:12 LairdWT

I recently cloned the project and have not changed anything just testing the latest version where i got the crash shortly after start. So far it seems all correct implemented as mentioned it's the original project.

mss10001 avatar Dec 05 '23 18:12 mss10001

Hi! How are you able to create this crash. I tried spawning hundreds of them and have yet to crash on this.

tomlooman avatar Dec 11 '23 11:12 tomlooman

Hi! How are you able to create this crash. I tried spawning hundreds of them and have yet to crash on this.

I just playing and fireing like the hell and i get this crash. I've nothing changed on your project.

Checked it just now and get the crash. Here some debug infos:

ACtionRougeCrahs

mss10001 avatar Dec 11 '23 13:12 mss10001

Thanks for the additional info, this is helpful. I still haven't been able to reach this crash myself. I'll keep an eye on this since I'd like to find out why this could even fail rather than just adding that safety check without fully understanding why it's not properly uninitializing.

tomlooman avatar Dec 14 '23 16:12 tomlooman