Revadike

Results 375 comments of Revadike

Other TODO suggestions: - [x] Merge or close open pull requests - [ ] Replace deprecated `request` module (I recommend `got`) - [x] Use `ESLint` for formatting (My [ESLint config](https://github.com/Revadike/RevaBot/blob/master/.eslintrc.json))...

I highly suggest setting up ESLint, so you don't have to format each file manually. ESLint can format on-save and fix formatting rules.

How do you feel about converting the prototypes to classes?

> > How do you feel about converting the prototypes to classes? > > I'm thinking about it. I don't really see much reason not to. > > Is there...

Yeah, it seems you still need to use prototyping to extend the main SteamCommunity class.

> What about adding declaration files for better ide autocompletion and inline documentation? If you prefer translating the code to typescript, i can help too. I think I saw someone...

https://github.com/DoctorMcKay/node-steamcommunity/issues/282 for TODO :)

Any chance this is related to `getGiftDetails | HTTP error 404` errors, I were getting? I'm suspecting, it was caused by an invalid `getUserInventoryContents` response where gifts had no `id`,...

@DoctorMcKay why did this get closed? Was it not proper enough?

Sure, give it another review, and perhaps I could fork it and address your feedback, if needed.