SteamWebIntegration icon indicating copy to clipboard operation
SteamWebIntegration copied to clipboard

Changing attributes (src, href) not detected

Open Revadike opened this issue 6 years ago • 8 comments

Revadike avatar Apr 19 '19 10:04 Revadike

https://github.com/Revadike/SteamWebIntegration/blob/45c3bf5fa29d23e140176e9fc383c2909d62890f/Steam%20Web%20Integration.user.js#L512 It looks like you've only been observing added and that's it.

bestpika avatar Mar 19 '21 16:03 bestpika

https://github.com/Revadike/SteamWebIntegration/blob/45c3bf5fa29d23e140176e9fc383c2909d62890f/Steam%20Web%20Integration.user.js#L512

It looks like you've only been observing added and that's it.

https://github.com/kapetan/jquery-observe I don't think it provides an observer for changed. Perhaps I should switch to plain MutationObserver. I think I considered this in the past, but some reason decided not do it. I forgot why though.

Revadike avatar Mar 19 '21 16:03 Revadike

Directly using MutationObserver can catch the attribute changes of subtree, no problem. (I deleted the one a few minutes ago with a mistake.)

bestpika avatar Oct 07 '21 08:10 bestpika

Just add "subtree": true to the $('body').observe setting and it will detect it, but you still have to deal with the stuff that comes out every time it changes.

bestpika avatar Oct 07 '21 08:10 bestpika

Not detecting game ownership and other game specific flags on fanatical, when looking at bundle page at product details (game info) slider . All games are shown as unowned and game with cards, even if I own the game and game has no cards.

Adding to the fanatical issue: This might just be a coincidence but when viewing older bundle I have already purchased. It shows the correct attributes for the first game in bundle, but only some times for the other games. With other games in the same bundle it show the attributes of the first game.

When I scroll through the product details slider and reach the beginning of the slider again, another container with the same attributes shows up next to the first one, so as many times I scroll through to the beginning it adds another attribute box.

dokiiin avatar Apr 30 '22 17:04 dokiiin

Not detecting game ownership and other game specific flags on fanatical, when looking at bundle page at product details (game info) slider . All games are shown as unowned and game with cards, even if I own the game and game has no cards.

If you really need to see these on Fanatical, you could always use "Clear and run" from your right-click or extension menu. image

..but why don't you just use a less disgusting website to browse their bundle contents? https://barter.vg/bundle/6142/ , https://www.steamgifts.com/discussion/i2qT2/ or even ITAD, gg deals, ...

Luckz avatar May 03 '22 02:05 Luckz

If you really need to see these on Fanatical, you could always use "Clear and run" from your right-click or extension menu.

That only works for one game at a time, switching to the next shows the previous game attributes.

dokiiin avatar May 03 '22 12:05 dokiiin

Sure.

Luckz avatar May 04 '22 01:05 Luckz

Fixed in v2.1.0

Revadike avatar Feb 28 '23 06:02 Revadike