RMG-Py icon indicating copy to clipboard operation
RMG-Py copied to clipboard

Minor: Update group attribute name to py3

Open hwpang opened this issue 5 years ago • 8 comments

Motivation or Problem

  1. hasWildCards should be has_wildcards
  2. standardize_atomtype() function throws attribute error because Group() doesn't have has_wildcards attribute. It really should be a checking done on the atoms.

Description of Changes

  1. Changed from hasWildCards to has_wildcards
  2. Add a for loop to loop through self.atoms and changed self.has_wildcards to atom.has_wildcards.

hwpang avatar Jun 09 '20 23:06 hwpang

Codecov Report

Merging #1979 (295db47) into main (c68ba9a) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 295db47 differs from pull request most recent head 2b66c31. Consider uploading reports for the commit 2b66c31 to get more accurate results

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   48.25%   48.25%   -0.01%     
==========================================
  Files         110      110              
  Lines       30616    30737     +121     
  Branches     7982     8062      +80     
==========================================
+ Hits        14774    14831      +57     
- Misses      14298    14344      +46     
- Partials     1544     1562      +18     
Impacted Files Coverage Δ
arkane/kinetics.py 12.24% <0.00%> (ø)
rmgpy/rmg/reactors.py 26.99% <0.00%> (+6.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 10 '20 00:06 codecov[bot]

This is fine but the changes order doesn't make much sense. Can you split the creation of the has_wildcards function into one commit and the naming/calling changes in to a second commit?

Thanks for the review! Commits updated!

hwpang avatar Aug 07 '20 15:08 hwpang

Can you rebase?

mjohnson541 avatar Aug 20 '20 23:08 mjohnson541

Can you rebase?

Rebased!

hwpang avatar Aug 20 '20 23:08 hwpang

Sorry, can you rebase again?

mjohnson541 avatar May 13 '21 18:05 mjohnson541

Sorry, can you rebase again?

mjohnson541 avatar May 14 '21 16:05 mjohnson541

@mjohnson541 Rebased!

hwpang avatar Jun 21 '21 19:06 hwpang

Rebased again!

hwpang avatar Jun 22 '21 17:06 hwpang

@kspieks Thanks for the review! The unit test is just added!

hwpang avatar Mar 02 '23 16:03 hwpang

@hwpang can you please rebase? I'll merge immediately since all tests have already passed

kspieks avatar Mar 02 '23 21:03 kspieks