axios-cache-adapter icon indicating copy to clipboard operation
axios-cache-adapter copied to clipboard

Add support for axios 0.22.* 0.23.* and 0.24.*

Open ganey opened this issue 4 years ago • 6 comments

ganey avatar Oct 18 '21 13:10 ganey

Codecov Report

Merging #261 (036a80c) into master (2d51cee) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          235       234    -1     
=========================================
- Hits           235       234    -1     
Impacted Files Coverage Δ
src/serialize.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d51cee...036a80c. Read the comment docs.

codecov[bot] avatar Oct 18 '21 13:10 codecov[bot]

Current axios version is now 0.23.0

timtucker-dte avatar Oct 20 '21 16:10 timtucker-dte

Current axios version is now 0.23.0

I'm not confident with 0.23.0 yet as i'm not sure if the 'breaking changes' section of the axios change log affects the cache adapter in any way

ganey avatar Oct 20 '21 16:10 ganey

Current axios version is now 0.23.0

I'm not confident with 0.23.0 yet as i'm not sure if the 'breaking changes' section of the axios change log affects the cache adapter in any way

The 0.23.0 release only seem to include TS type declarations updates and test improvements. 0.24.0 is also only type declarations according to the change log.

pstenstrm avatar Dec 13 '21 21:12 pstenstrm

Thanks @pstenstrm I've updated the semver in the PR to >=0.21.1 <0.25.0 to include all of 0.23 and 0.24

ganey avatar Dec 14 '21 07:12 ganey

Current version is 0.25, peerDependency constraint should be >= 0.21.1 <1 considering that none of them will have breaking changes should not be a reason to strictly block versions below 1.

recs182 avatar Jan 26 '22 19:01 recs182