ros2arduino icon indicating copy to clipboard operation
ros2arduino copied to clipboard

ros2 service replier

Open amfern opened this issue 4 years ago • 5 comments

Implements ROS2 service

amfern avatar Dec 28 '20 22:12 amfern

This resolves #51

amfern avatar Dec 28 '20 22:12 amfern

ping @OpusK, hey can you take a look?

amfern avatar Jan 13 '21 12:01 amfern

Regarding this CI failure: https://travis-ci.org/github/ROBOTIS-GIT/ros2arduino/builds/751887104#L405

In file included from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/SafeRingBuffer.h:25:0,
                 from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/Uart.h:23,
                 from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/variants/mkr1000/variant.h:164,
                 from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/Arduino.h:48,
                 from sketch/subscriber.ino.cpp:1:
/home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/sync.h:28:22: error: expected unqualified-id before 'for'
 #define synchronized for (__Guard __guard; __guard.enter(); )
                      ^
/home/travis/arduino_ide/libraries/ros2arduino/src/ros2/xrcedds/micro_xrce_dds/lib/include/uxr/client/core/session/session.h:97:10: note: in expansion of macro 'synchronized'
     bool synchronized;
          ^~~~~~~~~~~~
/home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/sync.h:28:44: error: '__guard' does not name a type; did you mean '__Guard'?
 #define synchronized for (__Guard __guard; __guard.enter(); )
                                            ^
/home/travis/arduino_ide/libraries/ros2arduino/src/ros2/xrcedds/micro_xrce_dds/lib/include/uxr/client/core/session/session.h:97:10: note: in expansion of macro 'synchronized'
     bool synchronized;
          ^~~~~~~~~~~~
/home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/sync.h:28:61: error: expected unqualified-id before ')' token
 #define synchronized for (__Guard __guard; __guard.enter(); )
                                                             ^
/home/travis/arduino_ide/libraries/ros2arduino/src/ros2/xrcedds/micro_xrce_dds/lib/include/uxr/client/core/session/session.h:97:10: note: in expansion of macro 'synchronized'
     bool synchronized;
          ^~~~~~~~~~~~
exit status 1

It has been reported here: https://github.com/arduino/ArduinoCore-samd/issues/596 I don't think it is related to the changes made in this pull request in any way. It's simply that the breakage was introduced in the 1.8.11 release of the Arduino SAMD Boards platform on 2020-12-24, which came after the last CI run, but before this PR was submitted. If you compile the ros2arduino code from the master branch with Arduino SAMD Boards 1.8.11 you'll get the same error.

per1234 avatar Feb 02 '21 12:02 per1234

@amfern Sorry for the late.

Unfortunately, I no longer have administrative rights to this repo...

OpusK avatar Mar 17 '21 08:03 OpusK

Thanks for coming back, i learn alot when tinckering with this repo. And i already moved on to micro_ros_arduino

amfern avatar Mar 17 '21 13:03 amfern