Brandon Nozaki Miller comments

Results 101 comments of


                                            Brandon Nozaki Miller

Let this work with vanilla ES6

I decided to follow up and check if the window object was exposed when importing the npm ES6 module natively. Sure enough it is. This does not follow the documentation,...

Let this work with vanilla ES6

If you write a native ESM module, without transpiling, you actually do need to use `window.AdyenCheckout` because neither the NPM module, nor the script tag install, export a named `AdyenCheckout`...

Let this work with vanilla ES6

OK, so this is just my first pass at the Drop-In implementation. By no means is it complete, it's just a native ESM/ES6 example. I spent a couple of hours...

Let this work with vanilla ES6

Btw, as an update, if I import the module with a bogus name I can access it as you suggest, but again this is not how it is documented nor...

Let this work with vanilla ES6

Hi @deepu105 I understand what you are saying. The main thing I think would be good, and easy, to do is update the docs to be accurate. Even if Adyen...

Let this work with vanilla ES6

@nickcaballero yup, that's the quick fix I'm suggesting for the docs just above @deepu105's post [it's the last code snippet here](https://github.com/Adyen/adyen-web/issues/639#issuecomment-756512583) Added it here so you don't have to actually...

Let this work with vanilla ES6

A form of the suggested documentation was pushed to prod in the docs. Also, I am now a member of the dev advocate at Adyen. Woot for filing tickets!

Let this work with vanilla ES6

I see these changes were reverted after I noted the change. This brings this issue back to life.

ci: fix nodejs matrix

I don't think this is accurate. Can you provide a documentation link for it?

Unlink socket file when serve new one and create parent path if it does not already exit.

Just saw this, looks useful. I want to review the dependency additions and probably needs documentation too.