quilt-standard-libraries icon indicating copy to clipboard operation
quilt-standard-libraries copied to clipboard

Published 20 hours ago • verified publisher icon QuiltMC

Make TrackedDataHandler registration use registry

Open Patbox opened this issue 3 years ago • 2 comments

This change allows for better mod compatibility, as now TrackedDataHandler's ids can be synced between server and client

Patbox avatar Aug 21 '22 13:08 Patbox

LGTM! Though... Don't TrackedDatas use load order-dependent raw IDs too?

They do, but thats for different PR

Patbox avatar Aug 21 '22 14:08 Patbox

Last commit failed because of some issue with quilt's maven. So it's not an issue™

Patbox avatar Aug 31 '22 19:08 Patbox

Attempts to test this PR on production have failed; Marking this as s: not working

EnnuiL avatar Sep 11 '22 00:09 EnnuiL

It's issue with buildscript, as it generates same refmap name as networking module. Someone more experienced in that should look into fixing that

Patbox avatar Sep 11 '22 09:09 Patbox

Issue should be solved now. Rename the module so it doesn't colide with core/networking

Patbox avatar Sep 12 '22 19:09 Patbox

Testing went well! I'd request a Checkstyle pass, but this whole exchange is exhausting, so I'll do something on merge

EnnuiL avatar Sep 29 '22 22:09 EnnuiL

A Checkstyle pass will be done soonish, but now? It's merge time

EnnuiL avatar Oct 08 '22 17:10 EnnuiL