lecture-python-intro icon indicating copy to clipboard operation
lecture-python-intro copied to clipboard

[cagan_adaptive] Editorial Suggestions

Open HumphreyYang opened this issue 1 year ago • 3 comments

Code

  • [x] change the name create_cagan_model to create_cagan_adaptive_model
  • [x] Set the default values in create_cagan_adaptive_model instead of global parameters.
  • [ ] Add code comment to the code.
  • [x] change inv to solve.
  • [x] remove extra print when checking the stability of dynamics. in the section of 14.6. Technical condition for stability and add a new section that focuses on experiments.

Content

  • [x] 'monetarist theory of price levels ' -> 'a monetarist theory of price levels '.
  • [x] There is an extra quotation mark at the end of the second sentence.
  • [x] $exp(\frac{m^d_t}{p_t})$ -> $exp(m^d_t - p_t)$.
  • [ ] Explain the variables such as sensitivity and expected rate of inflation and give admissible range of the parameters.
  • [x] endogenous input -> exogenous input
  • [x] give names to matrices and equations so that they can be referred in the code comment.
  • [x] Add comments in this function and give titles to subplots.
  • [x] Change subtitle "Forcast error" -> "Forcast error and model computation"
  • [x] Change the time notations for equations in the section "Experiment 1"
  • [ ] Add an exercise that asks readers to explain the phenomenon in experiment 1.

HumphreyYang avatar Mar 10 '24 22:03 HumphreyYang

@jstac Hi John, I want to create a pull request for the following suggestions in the lecture [cagan_adaptive]. Do you think these are non-controversial?

  • [x] Set the default values in create_cagan_adaptive_model instead of global parameters.
  • [x] change inv to solve.
  • [x] remove extra print when checking the stability of dynamics. in the section of 14.6. Technical condition for stability and add a new section that focuses on experiments.
  • [x] give names to matrices and equations so that they can be referred in the code comment.
  • [x] Add comments in this function and give titles to subplots.
  • [x] Change subtitle "Forcast error" -> "Forcast error and model computation"
  • [x] Change the time notations for equations in the section "Experiment 1"

longye-tian avatar Mar 13 '24 11:03 longye-tian

@longye-tian No, those are not controversial and will definitely improve the lecture. Please go ahead!

jstac avatar Mar 13 '24 18:03 jstac

Thank you for your feedback!

I'll proceed with implementing them to enhance the lecture.

longye-tian avatar Mar 13 '24 23:03 longye-tian

This issue is now closed.

longye-tian avatar Jul 19 '24 06:07 longye-tian