flake8-bugbear

flake8-bugbear copied to clipboard

Correct code:

try:
    from foo import bar
    from spam import eggs
except ImportError:
    from another_foo import bar
    from another_spam import eggs

Bad code:

try:
    from foo import bar
    from spam import eggs
except ImportError:
    # [ Missing import for `bar` ]
    from another_spam import eggs

PyCharm IDE gives a nice warning:

'variable_name' in the try block with 'except ImportError' should also be defined in the except block

Flake8 does not detect this problem.

I don't know if we can always cleanly detect this and if it would be high signal. Someone could also do:

bar = None
try:
    from foo import bar
except ImportError:
    pass

def some_function():
    if bar:
        do_something()

Adding this would create noise here for some users.

Adding this would create noise here for some users.

Is there an easy way to add opt-in checks? In other words, that are disabled by default, but can be enabled via include=<ERROR_CODE>,

UPD:

Sorry, there is already --extend-select command. I forgot about it. Maybe this warning can be implemented as optional.