Punit Lodha

Results 56 comments of Punit Lodha

1 is just removing the CSS from the signal-viewer component, so that the table component CSS is used(Due to the global nature of CSS). If you want to keep CSS...

Is the signal viewer component static(unlike the timeline component)? If it is then i can try to reuse the table component in it

Hey @domoritz . I am new to Open Source. I would like to work on this issue. Should i replace the classes by the tachyons classes?

I have sent a PR. Please review it. If its good, then i shall start working on the other components

Should we start using BEM for structuring the CSS?

Could you share the output of `ccextractor --version`?

You are using version 0.89. Could you try using the latest version(0.94)?

You could send a PR. If it doesn't cause any issues with the other tests, then we can merge it

> **Ubuntu 20.04.4 LTS** ccextractor 0.94, compiled from github commit ca303d, 2022-04-11 command: -svc all -nofc -dru get: empty .srt file. good .p0.svc01.srt file with 9 sets of CCs, but...