standards icon indicating copy to clipboard operation
standards copied to clipboard

Improve PHP-CS-Fixer and PHPStan caching

Open szepeviktor opened this issue 1 year ago • 6 comments

🕶️ I do not know what I'm doing but there were issues.

image

szepeviktor avatar Jan 09 '24 13:01 szepeviktor

But one thing is for sure: cache keys should not contain git branch names.

szepeviktor avatar Jan 09 '24 13:01 szepeviktor

🌧️ Bad day for GitHub

Internal server error occurred while resolving "actions/checkout@v3". Internal server error occurred while resolving "shivammathur/setup-php@v2"

https://www.githubstatus.com/incidents/pxg3dz4yg7lp

szepeviktor avatar Jan 09 '24 13:01 szepeviktor

Not really working ...

image

szepeviktor avatar Jan 09 '24 13:01 szepeviktor

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (43d73b0) 100.00% compared to head (5684227) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #158   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       231       231           
===========================================
  Files             33        33           
  Lines           3611      3611           
===========================================
  Hits            3611      3611           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 09 '24 13:01 codecov[bot]

"always() save" fails. What to do?

image

szepeviktor avatar Jan 09 '24 14:01 szepeviktor

@szepeviktor That's because caches are immutable, and that's why the 'gh actions-cache delete' was there that is removed in this pr. ;)

See https://github.com/actions/cache/blob/main/tips-and-workarounds.md#update-a-cache

PrinsFrank avatar Jan 09 '24 14:01 PrinsFrank

@PrinsFrank Weather Forecast 🎵 for stalled PR-s: https://www.youtube.com/watch?v=jyavOPntNho (including the Spitsbergen)

szepeviktor avatar Jan 17 '24 01:01 szepeviktor

The CI workflows have been moved over to https://github.com/PrinsFrank/CI-PHP. Feel free to add a PR there. Thanks again!

PrinsFrank avatar Feb 03 '24 16:02 PrinsFrank