PsyNeuLink icon indicating copy to clipboard operation
PsyNeuLink copied to clipboard
verified publisher icon PrincetonUniversity

Feat/autodiff/rnn

Open SamKG opened this issue 5 years ago • 10 comments

SamKG avatar Jul 21 '20 14:07 SamKG

This pull request introduces 35 alerts and fixes 2 when merging a5bff967ee9cefc6829fb9b62abcd59dd23bcfbe into 07af71504a31b57944a0fc743bc6e6bf17c3fef8 - view on LGTM.com

new alerts:

  • 24 for Unused import
  • 9 for Unused local variable
  • 1 for Asserting a tuple
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 21 '20 15:07 lgtm-com[bot]

retest this please

SamKG avatar Jul 21 '20 16:07 SamKG

retest this please

SamKG avatar Jul 21 '20 17:07 SamKG

This pull request introduces 2 alerts and fixes 2 when merging d20fa6fa4e6ed76354ebe242de87d911dc81934f into 07af71504a31b57944a0fc743bc6e6bf17c3fef8 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 21 '20 18:07 lgtm-com[bot]

The mxm and outer_product parts look.

The rest of the compiled parts needs significant rework to use standard tools (or add comments why that is not possible)

To be more specific here. I think the LSTM function should have its own class rather than a rather hacky approach of using UDF, since you're writing the important parts anyway it shouldn't be too difficult and it will lead to clearer structure (including LLVM implementation). It should also have standalone tests.

Custom _get_state_struct and _get_param_struct should be avoided if possible. The reason why mechanism's function is not included by default is the presence of special functions (like memory functions). Other Function typed parameters should work without any special handling.

jvesely avatar Jul 23 '20 21:07 jvesely

This pull request introduces 2 alerts and fixes 2 when merging 5a083e6fcc6ee6202e6ef7fb70b4ac3d1585c1d3 into c7afc350a326669665e0ee86f8144c0b8fff8d17 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 25 '20 23:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 2 when merging 45c5d1ddfdb8fec91d011a02c54cc4a9f2054624 into c7afc350a326669665e0ee86f8144c0b8fff8d17 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 26 '20 06:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 2 when merging b1769804467fb9b33b33eefc0c425277e261503f into c7afc350a326669665e0ee86f8144c0b8fff8d17 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 27 '20 04:07 lgtm-com[bot]

This pull request introduces 2 alerts and fixes 2 when merging fe1830689a54acc87ffecb1c4b5e2ae816ae17dd into c7afc350a326669665e0ee86f8144c0b8fff8d17 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 27 '20 05:07 lgtm-com[bot]

This pull request introduces 2 alerts and fixes 2 when merging b99cd4b91ecb49c880918e8a8cf12c4ccf88eb81 into e31dc28023ce906ec901943c13e0a9e787a089ff - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 2 for Unused local variable

lgtm-com[bot] avatar Jul 28 '20 15:07 lgtm-com[bot]