nestjs-geteventstore icon indicating copy to clipboard operation
nestjs-geteventstore copied to clipboard

Published 20 hours ago • verified publisher icon PrestaShopCorp

Persistent Subscription Handler function has wrong signature.

Open sixtay opened this issue 3 years ago • 3 comments

https://github.com/PrestaShopCorp/nestjs-geteventstore/blob/3a14375624d53521fa3aad698c6729f1234dbf59/src/event-store/services/event-store.service.ts#L308

This doesn't look correct. Payload will always be undefined and will break. Please advise

sixtay avatar Apr 30 '22 18:04 sixtay

@sixtay would you be able to submit a PR for this fix?

kodeine avatar May 05 '22 14:05 kodeine

Possibly. It seems this issue stems from the subscription leveraging 'node-eventstore-client' instead of @eventstore/db-client.

I'll look into a fix.

For now I just modified juicyclef's package to create persistent subscriptions and use append to individual aggregate streams.

sixtay avatar May 05 '22 14:05 sixtay

Juicyjeffs package uses eventstore 5.x. This package supports that in 4.x branch and the master branch should support eventstore 20.x

kodeine avatar May 11 '22 21:05 kodeine