livewire-powergrid

livewire-powergrid copied to clipboard

Adds Multiple Column Sorting

set public $multiSort to true

Unable to test a clean pull. Please run a test if you don't mind

Hi, thanks for submitting your PR to powergrid!.

I will be analyzing some points because there is still much to discuss.

Do you have an example showing how it works or could you submit a test?

Below is a video had to apply a fix for collections to work.

In the video I have an output at the top of the table which is not in PR below is the code for it.

@php print_r($sortArray) @endphp

https://user-images.githubusercontent.com/64607188/183519769-108c2668-90da-4863-8c7b-baacd305e162.mp4

There are some things in your PR that are lagging behind main and have been removed in your PR.

L:152,187,301

I believe this has been fixed in my latest commit

Test failing is another issue with doctrine/dbal version 3.4. not related

@luanfreitasdev is there any more work that needs to be completed for this to go into production?

I marked it for the next version 4, because of the complexity. I'm thinking of testing it out before merging. Documentation is also missing.

I marked it for the next version 4, because of the complexity. I'm thinking of testing it out before merging. Documentation is also missing.

Sounds great! will try to get some basic documentation for you