posthog
posthog copied to clipboard
feat(web-analytics): Handle null values better in session properties
Problem
Null values are currently displayed as an empty string, and are not clickable.
Changes
- Make isNotSet work with session properties
- Send null instead of empty string for most session attribution properties
- Make null values clickable in web analytics
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added tests for the queries, clicked a bunch of tables with null and non-null values on the front end
đ Existing Issues For Review
Your pull request is modifying functions with the following pre-existing issues:
đ File: posthog/hogql/property.py
| Function | Unhandled Issue |
|---|---|
property_to_expr |
Cohort.DoesNotExist: Cohort matching query does not exist. posthog.tasks.tasks.process_... Event Count: 5 |
property_to_expr |
NotImplementedError: property_to_expr for element selector only supports exact and is_not operators, not icontains ... Event Count: 3 |
Did you find this useful? React with a đ or đ
Size Change: 0 B
Total Size: 1.06 MB
âšī¸ View Unchanged
| Filename | Size |
|---|---|
frontend/dist/toolbar.js |
1.06 MB |