posthog icon indicating copy to clipboard operation
posthog copied to clipboard

feat: Upgrade and improve social auth flow

Open benjackwhite opened this issue 1 year ago â€ĸ 4 comments
trafficstars

Problem

The social auth flow doesn't seem to work for first time org creations. The signup itself goes through but the linking to the associated social auth doesn't.

Part of the issue is we have a partially created user situation which feels a little messy. Instead we should allow standard signup followed by org creation to make this way more reliable.

Changes

  • Upgrades the underyling social auth lib
  • Pulls out some of the pipeline to our own code to add extra fixes and tweaks

TODO

  • [ ] Update to make sure the full signup happens, followed by an organization creation if one doesn't exist

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

benjackwhite avatar May 22 '24 15:05 benjackwhite

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/api/signup.py

Function Unhandled Issue
social_create_user ValidationError: ["This invite is intended for another email address."] ...
Event Count: 32

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar May 22 '24 15:05 sentry[bot]

Size Change: -65 B (-0.01%)

Total Size: 1.03 MB

â„šī¸ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.03 MB -65 B (-0.01%)

compressed-size-action

github-actions[bot] avatar May 22 '24 19:05 github-actions[bot]

📸 UI snapshots have been updated

95 snapshot changes in total. 0 added, 95 modified, 0 deleted:

  • chromium: 0 added, 95 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 22 '24 19:05 posthog-bot

📸 UI snapshots have been updated

86 snapshot changes in total. 0 added, 86 modified, 0 deleted:

  • chromium: 0 added, 86 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot avatar May 23 '24 19:05 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 31 '24 07:05 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jun 10 '24 07:06 posthog-bot

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar Jun 18 '24 07:06 posthog-bot